cleanup travis build file #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #12 +/- ##
==========================================
- Coverage 89.60% 89.34% -0.26%
==========================================
Files 7 7
Lines 779 779
==========================================
- Hits 698 696 -2
- Misses 53 54 +1
- Partials 28 29 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
haugenj
reviewed
Jun 22, 2020
| language: go | ||
| go: "1.14.x" | ||
| script: make unit-test | ||
| env: GO_UNIT_TESTS=TRUE |
Contributor
There was a problem hiding this comment.
Are these vars used anywhere else? Forgive my lack of Travis knowledge but my thinking is that there's another location these need to be removed from
Contributor
Author
There was a problem hiding this comment.
nope, these were there because I didn't realize there was a name field for a travis job. The Travis job running page displays env vars, so I was using these to label the tests, but they're not needed since the jobs are named now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
Improve travis build file w/ names per job and building binaries + docker images on all builds to exercise those paths outside of releases.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.